hooks: support dynamic tools in PreToolUse/PostToolUse#20335
Closed
eternal-openai wants to merge 7 commits into
Closed
hooks: support dynamic tools in PreToolUse/PostToolUse#20335eternal-openai wants to merge 7 commits into
eternal-openai wants to merge 7 commits into
Conversation
This was referenced May 2, 2026
3e61061 to
7dc4444
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After tightening dynamic tool registration to the same identifier contract that Responses actually accepts, we can extend Codex's hook support to dynamic tools using the same plain tool identities that already exist on the model-facing surface.
This keeps hook matching aligned with the tool names app-server and Responses already use, instead of inventing a separate dynamic-only namespace. It also makes dynamic tool hooks behave like the existing function-style tool hooks we already support.
What changed
PreToolUseandPostToolUseto dynamic tools by teachingDynamicToolHandlerto build hook payloads from parsed JSON argumentstool_nameasnamespace__tool, while plain dynamic tools keep their plain tool namenamespace__toolform ambiguous, so matcher identities stay injective even when identifiers contain edge or repeated underscorestool_responsewith the same body shape the model sees: a JSON string for a single text item, or the full content-item array for richer outputPermissionRequestflows in this passVerification
cargo test -p codex-hookscargo test -p codex-core hooks_dynamiccargo test -p codex-core for_dynamic_tool_cargo test -p codex-core dynamic_post_tool_use_Docs
No external docs update is needed for this stacked change.