app-server: use connection-specific thread unload delays#20487
Closed
euroelessar wants to merge 2 commits into
Closed
app-server: use connection-specific thread unload delays#20487euroelessar wants to merge 2 commits into
euroelessar wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eaf60c2b68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Threads are eligible for unload after the last connection unsubscribes, but the appropriate grace period depends on the connection type. Local in-process and stdio clients can release immediately after the last subscriber leaves, while socket, TCP websocket, and remote-control clients should keep the existing 30-minute grace window to preserve reconnect behavior.
What changed
ConnectionOrigin.ThreadStateManagerpublish whether subscribers exist plus the winning unload delay, using the maximum delay among active subscribers and retaining that value once the thread becomes idle.Verification
git diff --check ae863e72a27a283c08023dcf039871c917209120CARGO_TARGET_DIR=/tmp/codex-app-server-target cargo test -p codex-app-server connection_origin_sets_thread_unloading_delayCARGO_TARGET_DIR=/tmp/codex-app-server-target cargo test -p codex-app-server adding_connection_to_thread_updates_subscription_watcherCARGO_TARGET_DIR=/tmp/codex-app-server-target cargo test -p codex-app-server thread_unsubscribe_over_stdioCARGO_TARGET_DIR=/tmp/codex-app-server-target cargo test -p codex-app-server thread_unsubscribe_during_turn_keeps_turn_running