Skip to content

app-server: move transport into dedicated crate#20545

Merged
euroelessar merged 3 commits intomainfrom
ruslan/app-server-transport-crate
May 1, 2026
Merged

app-server: move transport into dedicated crate#20545
euroelessar merged 3 commits intomainfrom
ruslan/app-server-transport-crate

Conversation

@euroelessar
Copy link
Copy Markdown
Collaborator

Why

codex-app-server currently owns both request-processing code and transport implementation details. Splitting the transport layer into its own crate makes that boundary explicit, reduces the amount of transport-specific dependency surface carried by codex-app-server, and gives future transport work a narrower place to evolve.

What changed

  • Added codex-app-server-transport and moved the existing transport tree into it, including stdio, unix socket, websocket, remote-control transport, and websocket auth.
  • Moved shared transport-facing message types into the new crate so both the transport implementation and codex-app-server use the same definitions.
  • Kept processor-facing connection state and outbound routing in codex-app-server, with the routing tests moved next to that local wrapper.
  • Updated workspace metadata, Bazel crate metadata, and codex-app-server dependencies for the new crate boundary.

Validation

  • cargo metadata --locked --no-deps
  • git diff --check
  • Attempted cargo test -p codex-app-server-transport, cargo test -p codex-app-server, just fix -p codex-app-server-transport, and just fix -p codex-app-server; all were blocked before compilation by the existing packageproxy resolution failure for locked rustls-webpki = 0.103.13.
  • Attempted Bazel build / lockfile validation; those were blocked by external fetch failures against BuildBuddy / GitHub while resolving v8.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b5d7d0bc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/transport.rs
@euroelessar euroelessar merged commit 41e171f into main May 1, 2026
28 checks passed
@euroelessar euroelessar deleted the ruslan/app-server-transport-crate branch May 1, 2026 16:23
@github-actions github-actions Bot locked and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants