Skip to content

codex: migrate (more) app-server thread history reads to ThreadStore#20575

Merged
wiltzius-openai merged 1 commit intomainfrom
wiltzius/codex/thread-store-app-server-migration
May 5, 2026
Merged

codex: migrate (more) app-server thread history reads to ThreadStore#20575
wiltzius-openai merged 1 commit intomainfrom
wiltzius/codex/thread-store-app-server-migration

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented May 1, 2026

Migrate token usage replay, rollback responses, and detached review setup (a special case of forking) to be served from ThreadStore reads rather direct rollout files.

  • replay restored token usage from already-loaded RolloutItem history instead of reopening Thread.path
  • rebuild rollback responses from loaded ThreadStore snapshots and history
  • start detached reviews from store-backed parent history and stored review-thread metadata
  • remove obsolete app-server rollout-summary helper code that became dead after the store-backed migration
  • preserve response/notification ordering for resume, fork, rollback, and detached review flows
  • add integration test coverage for the affected paths

Bojun-Vvibe added a commit to Bojun-Vvibe/oss-contributions that referenced this pull request May 1, 2026
- anomalyco/opencode#25265 merge-as-is: truecolor capability gate for logo subpixel rendering

- openai/codex#20585 merge-after-nits: cross-compile Windows Bazel CI mirroring macOS pattern

- openai/codex#20575 merge-after-nits: app-server thread reads migrated to ThreadStore
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 4160bf4 to 7b8b9ab Compare May 1, 2026 15:27
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 2 times, most recently from 040171c to 0f98012 Compare May 1, 2026 17:09
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 7b8b9ab to 3dda86b Compare May 1, 2026 17:09
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 0f98012 to 96ff4cf Compare May 1, 2026 17:15
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 3dda86b to 0ab9b96 Compare May 1, 2026 17:15
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 96ff4cf to 66a3536 Compare May 1, 2026 18:11
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 0ab9b96 to 34ea251 Compare May 1, 2026 18:11
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 66a3536 to 072f991 Compare May 1, 2026 18:47
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 34ea251 to a645067 Compare May 1, 2026 18:47
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 072f991 to a312dec Compare May 1, 2026 19:55
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch 3 times, most recently from d64ec1e to 4f8e5ae Compare May 1, 2026 20:05
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from a312dec to 1e07b6d Compare May 1, 2026 20:05
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 4f8e5ae to 9baeb0e Compare May 1, 2026 21:05
@wiltzius-openai wiltzius-openai changed the title codex: migrate app-server thread data reads to ThreadStore codex: migrate app-server thread history reads to ThreadStore May 1, 2026
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 9baeb0e to 9449f34 Compare May 1, 2026 21:23
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 2 times, most recently from 5a53f37 to 07ddf88 Compare May 1, 2026 21:32
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch 4 times, most recently from ec5e41f to c29f912 Compare May 1, 2026 22:07
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from b6e887d to 3cfe2d9 Compare May 1, 2026 22:29
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from c29f912 to 03fc03f Compare May 1, 2026 22:29
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 3 times, most recently from e0e9629 to 7cea9c9 Compare May 1, 2026 22:52
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 3 times, most recently from d87b44c to 1bc9368 Compare May 1, 2026 23:38
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 03fc03f to df8dd3a Compare May 1, 2026 23:44
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from 1bc9368 to 7e94adc Compare May 1, 2026 23:50
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch 2 times, most recently from d63d2d8 to efe8404 Compare May 4, 2026 22:15
@wiltzius-openai wiltzius-openai marked this pull request as ready for review May 4, 2026 22:39
@wiltzius-openai wiltzius-openai requested a review from a team as a code owner May 4, 2026 22:39
@wiltzius-openai wiltzius-openai changed the title codex: migrate app-server thread history reads to ThreadStore codex: migrate (more) app-server thread history reads to ThreadStore May 4, 2026
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch 3 times, most recently from b1ac602 to fdef4ce Compare May 4, 2026 23:54
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from efe8404 to 5f3e90b Compare May 4, 2026 23:54
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-live-metadata branch from fdef4ce to 7e67257 Compare May 5, 2026 00:19
Base automatically changed from wiltzius/codex/thread-store-live-metadata to main May 5, 2026 03:09
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-app-server-migration branch from 5f3e90b to 0469f07 Compare May 5, 2026 03:24
@wiltzius-openai wiltzius-openai merged commit 33d24b0 into main May 5, 2026
37 of 38 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/thread-store-app-server-migration branch May 5, 2026 04:16
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants