centralize approval prompts#20733
Closed
abhinav-oai wants to merge 12 commits into
Closed
Conversation
This was referenced May 2, 2026
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GuardianApprovalRequestas the single in-core description of an approval-worthy actionPermissionRequesthook payloads, and existing human-prompt transports from that one requestFlow
Before this change, each approval producer re-described the same action several times depending on the consumer:
Now each producer builds one
GuardianApprovalRequestonce, and the downstream paths project from it:GuardianApprovalRequestpermission_request_payload()derives the hook payload when that approval kind supports hooksThat leaves the external protocol stable while making approval-path changes land in one core area instead of being replumbed across every producer.