pin rollout references by segment#20915
Draft
friel-openai wants to merge 17 commits into
Draft
Conversation
9f8c353 to
95734ec
Compare
567b66a to
0b2d19a
Compare
95734ec to
104fe4b
Compare
0b2d19a to
ae91570
Compare
104fe4b to
446335c
Compare
ae91570 to
522b454
Compare
446335c to
c52479a
Compare
522b454 to
69e171b
Compare
c52479a to
b92592e
Compare
69e171b to
f31b73b
Compare
b92592e to
d1f451e
Compare
f31b73b to
b522933
Compare
d1f451e to
19b6fb2
Compare
b522933 to
7204165
Compare
19b6fb2 to
4999ef0
Compare
7204165 to
f31e385
Compare
4999ef0 to
96aa749
Compare
f31e385 to
bd6b6e1
Compare
96aa749 to
66f22f9
Compare
4b4592e to
9f412ed
Compare
66f22f9 to
afb219f
Compare
9f412ed to
51898d6
Compare
afb219f to
e07dd9f
Compare
51898d6 to
5d03f41
Compare
e07dd9f to
84a34f2
Compare
5d03f41 to
7d7772a
Compare
754d1bf to
9fb229c
Compare
54ed61f to
55bf692
Compare
This was referenced May 4, 2026
9fb229c to
5854eb9
Compare
55bf692 to
fe96fbd
Compare
5854eb9 to
e790912
Compare
fe96fbd to
aed4fad
Compare
e790912 to
c224273
Compare
aed4fad to
0cff133
Compare
7a8a82a to
1fa1409
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins rollout references to a specific rollout-storage
SegmentId.ThreadIdremains the runtime identity for sessions, app-server operations, TUI routing, state DB rows, model headers, and user-facing APIs.SegmentIdis only used to resolve a specific rollout JSONL segment.ForkReferencenow records{ thread_id, segment_id }, so references remain durable if a session later writes another rollout segment or the old segment is archived.This PR also keeps current compaction cleanup behavior: duplicate contiguous user messages are dropped during compaction, and unified exec max-process warning messages are filtered by prefix instead of using the old
exclude_from_compactionbehavior.This PR does not change default feature flags or release workflow behavior.
Validation
cargo test -p codex-rolloutCODEX_SKIP_VENDORED_BWRAP=1 cargo test -p codex-core thread_rollout_truncation -- --nocapturecargo test -p codex-app-server-protocolCODEX_SKIP_VENDORED_BWRAP=1 cargo build -p codex-cli --bin codex