Skip to content

pin rollout references by segment#20915

Draft
friel-openai wants to merge 17 commits into
dev/friel/frodex-129-fork-command-debugfrom
dev/friel/frodex-129-rollout-segment-references
Draft

pin rollout references by segment#20915
friel-openai wants to merge 17 commits into
dev/friel/frodex-129-fork-command-debugfrom
dev/friel/frodex-129-rollout-segment-references

Conversation

@friel-openai
Copy link
Copy Markdown
Contributor

@friel-openai friel-openai commented May 3, 2026

Summary

Pins rollout references to a specific rollout-storage SegmentId.

ThreadId remains the runtime identity for sessions, app-server operations, TUI routing, state DB rows, model headers, and user-facing APIs. SegmentId is only used to resolve a specific rollout JSONL segment. ForkReference now records { thread_id, segment_id }, so references remain durable if a session later writes another rollout segment or the old segment is archived.

This PR also keeps current compaction cleanup behavior: duplicate contiguous user messages are dropped during compaction, and unified exec max-process warning messages are filtered by prefix instead of using the old exclude_from_compaction behavior.

This PR does not change default feature flags or release workflow behavior.

Validation

  • cargo test -p codex-rollout
  • CODEX_SKIP_VENDORED_BWRAP=1 cargo test -p codex-core thread_rollout_truncation -- --nocapture
  • cargo test -p codex-app-server-protocol
  • CODEX_SKIP_VENDORED_BWRAP=1 cargo build -p codex-cli --bin codex

@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 9f8c353 to 95734ec Compare May 3, 2026 22:34
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 567b66a to 0b2d19a Compare May 3, 2026 22:35
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 95734ec to 104fe4b Compare May 3, 2026 22:44
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 0b2d19a to ae91570 Compare May 3, 2026 22:48
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 104fe4b to 446335c Compare May 3, 2026 23:24
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from ae91570 to 522b454 Compare May 3, 2026 23:25
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 446335c to c52479a Compare May 3, 2026 23:48
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 522b454 to 69e171b Compare May 3, 2026 23:51
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from c52479a to b92592e Compare May 4, 2026 00:08
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 69e171b to f31b73b Compare May 4, 2026 00:13
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from b92592e to d1f451e Compare May 4, 2026 00:21
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from f31b73b to b522933 Compare May 4, 2026 00:25
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from d1f451e to 19b6fb2 Compare May 4, 2026 00:36
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from b522933 to 7204165 Compare May 4, 2026 00:46
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 19b6fb2 to 4999ef0 Compare May 4, 2026 00:50
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 7204165 to f31e385 Compare May 4, 2026 00:52
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 4999ef0 to 96aa749 Compare May 4, 2026 01:02
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from f31e385 to bd6b6e1 Compare May 4, 2026 01:03
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 96aa749 to 66f22f9 Compare May 4, 2026 01:21
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 4b4592e to 9f412ed Compare May 4, 2026 01:21
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 66f22f9 to afb219f Compare May 4, 2026 01:24
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 9f412ed to 51898d6 Compare May 4, 2026 01:24
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from afb219f to e07dd9f Compare May 4, 2026 01:39
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 51898d6 to 5d03f41 Compare May 4, 2026 01:40
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from e07dd9f to 84a34f2 Compare May 4, 2026 01:48
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 5d03f41 to 7d7772a Compare May 4, 2026 01:49
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 754d1bf to 9fb229c Compare May 4, 2026 02:06
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 54ed61f to 55bf692 Compare May 4, 2026 02:07
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 9fb229c to 5854eb9 Compare May 4, 2026 02:16
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 55bf692 to fe96fbd Compare May 4, 2026 02:18
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from 5854eb9 to e790912 Compare May 4, 2026 02:22
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from fe96fbd to aed4fad Compare May 4, 2026 02:23
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-fork-command-debug branch from e790912 to c224273 Compare May 4, 2026 02:32
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from aed4fad to 0cff133 Compare May 4, 2026 02:32
@friel-openai friel-openai force-pushed the dev/friel/frodex-129-rollout-segment-references branch from 7a8a82a to 1fa1409 Compare May 4, 2026 02:50
@friel-openai friel-openai changed the title frodex: pin rollout references by segment pin rollout references by segment May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant