Skip to content

Add plugin ID to skill analytics#20923

Merged
alexsong-oai merged 3 commits intomainfrom
alexs/skill-pluginId
May 5, 2026
Merged

Add plugin ID to skill analytics#20923
alexsong-oai merged 3 commits intomainfrom
alexs/skill-pluginId

Conversation

@alexsong-oai
Copy link
Copy Markdown
Collaborator

Summary

  • thread plugin skill roots through the skills loader with their plugin ID
  • store plugin ID on loaded skill metadata for plugin-provided skills
  • include plugin ID on skill invocation analytics events

Test plan

  • cargo check -p codex-core-skills
  • cargo check -p codex-core -p codex-core-plugins -p codex-analytics
  • cargo check -p codex-tui
  • cargo check -p codex-plugin -p codex-core -p codex-core-plugins -p codex-analytics
  • cargo check -p codex-app-server
  • cargo test -p codex-analytics
  • HOME=/private/tmp/codex-empty-home cargo test -p codex-core-skills
  • just fix -p codex-core-skills
  • just fix -p codex-analytics
  • just fix -p codex-core-plugins
  • just fix -p codex-core
  • just fmt
  • git diff --check

@alexsong-oai alexsong-oai requested a review from a team as a code owner May 4, 2026 00:57
@alexsong-oai alexsong-oai enabled auto-merge (squash) May 4, 2026 00:57
@alexsong-oai
Copy link
Copy Markdown
Collaborator Author

@codex review

@alexsong-oai alexsong-oai marked this pull request as draft May 4, 2026 01:01
auto-merge was automatically disabled May 4, 2026 01:01

Pull request was converted to draft

@alexsong-oai
Copy link
Copy Markdown
Collaborator Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 124b5ab096

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/plugin/src/load_outcome.rs Outdated
@alexsong-oai
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alexsong-oai alexsong-oai marked this pull request as ready for review May 4, 2026 16:05
@alexsong-oai alexsong-oai merged commit 3ad7cf0 into main May 5, 2026
26 checks passed
@alexsong-oai alexsong-oai deleted the alexs/skill-pluginId branch May 5, 2026 03:36
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants