Skip to content

[codex] Add exact session lookup mode#21080

Draft
canvrno-oai wants to merge 5 commits into
mainfrom
codex/exact-session-name-lookup
Draft

[codex] Add exact session lookup mode#21080
canvrno-oai wants to merge 5 commits into
mainfrom
codex/exact-session-name-lookup

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented May 4, 2026

This PR adds an exact-name search mode to thread/list and uses it for startup resume/fork name lookups. The change is primarily a code cleanup: it keeps the exact-match decision in the app-server path instead of finishing that filtering in the TUI client.

What changed:

  • Adds a searchMode option to ThreadListParams with contains as the default behavior and exact for name lookups.
  • Applies exact filtering in the app-server while preserving the existing thread ordering and source/archive filters.
  • Updates the TUI startup resume/fork lookup to request exact matches from thread/list.
  • Regenerates the app-server schema and TypeScript protocol fixtures.
  • Updates existing app-server/TUI tests and call sites for the new request field.

Testing:

  • Ran just fmt from codex-rs.
  • Ran just write-app-server-schema from codex-rs.
  • Ran git diff --check 87d2235b5470d8969b51d80278a46aa30703eeab.

@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5c404c7f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/request_processors/thread_processor.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant