Skip to content

[codex] Use app/list for TUI app catalog#21085

Draft
canvrno-oai wants to merge 5 commits into
mainfrom
codex/tui-app-list-cleanup
Draft

[codex] Use app/list for TUI app catalog#21085
canvrno-oai wants to merge 5 commits into
mainfrom
codex/tui-app-list-cleanup

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented May 4, 2026

Summary

This code cleanup moves TUI app catalog loading onto the backend app/list API so the TUI no longer assembles accessible and directory apps itself. It also wires app/list/updated notifications into the TUI cache and keeps the existing behavior around startup readiness, thread cwd config, and local enable-disable races.

  • Request app lists through app-server from the TUI background request path.
  • Let the backend own merged app data and enabled state for /apps and $ mentions.
  • Preserve active thread cwd when evaluating app policy for app/list.
  • Send a backend follow-up update when Codex Apps is still finishing startup.
  • Update existing popup tests for backend-sourced app state and notification flow.

Testing

  • just fmt
  • git diff --check
  • cargo test -p codex-tui
  • cargo test -p codex-app-server

@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fca28782e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget.rs Outdated
canvrno-oai added a commit that referenced this pull request May 4, 2026
canvrno-oai added a commit that referenced this pull request May 5, 2026
@canvrno-oai canvrno-oai force-pushed the codex/tui-app-list-cleanup branch from 2d0e98b to de78ae1 Compare May 5, 2026 20:00
@canvrno-oai canvrno-oai force-pushed the codex/tui-app-list-cleanup branch from de78ae1 to 46d9abd Compare May 11, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant