Skip to content

Avoid whole plugin cache replacement on Windows#21103

Draft
zm-oai wants to merge 1 commit into
mainfrom
codex-windows-plugin-cache-version-activation
Draft

Avoid whole plugin cache replacement on Windows#21103
zm-oai wants to merge 1 commit into
mainfrom
codex-windows-plugin-cache-version-activation

Conversation

@zm-oai
Copy link
Copy Markdown

@zm-oai zm-oai commented May 4, 2026

Summary

  • keep the existing whole-root atomic plugin-cache replacement path for non-Windows
  • on Windows, activate installs at the plugin version directory instead of renaming the whole plugin cache root
  • clean up stale plugin versions best-effort after the new version is active
  • add Windows regression tests that hold cwd inside the existing plugin cache root while reinstalling/upgrading

Testing

  • cargo test -p codex-core-plugins --lib store::tests::windows_install
  • cargo clippy --tests --no-deps -p codex-core-plugins -- -D warnings
  • cargo fmt -p codex-core-plugins
  • git diff --check

Also ran cargo test -p codex-core-plugins --lib; the new Windows tests passed, but the full package run hit 4 unrelated Git-for-Windows/MSYS local-clone failures with CreateFileMapping / signal-pipe Win32 error 5.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant