[network-proxy] Cover DNS timeout blocking#21105
Merged
evawong-oai merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
viyatb-oai
requested changes
May 5, 2026
| } | ||
|
|
||
| async fn host_resolves_to_non_public_ip(host: &str, port: u16) -> bool { | ||
| host_resolves_to_non_public_ip_with_lookup( |
Collaborator
There was a problem hiding this comment.
can you make this into one function? this could be inlined instead of a function for a single function
Contributor
Author
There was a problem hiding this comment.
Done. I collapsed this into one function and kept the production lookup at the call site.
evawong-oai
force-pushed
the
codex/bugb15982-dns-timeout-test
branch
from
09aa423 to
378dc03
Compare
viyatb-oai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookup_hostbehavior.Why
BUGB 15982 was fixed by failing closed on DNS lookup errors and timeouts. The existing regression covered lookup failure through real DNS, but did not deterministically exercise the timeout branch. This PR adds a small injection point so CI can cover that branch without standing up slow authoritative DNS.
Validation
cargo test -p codex-network-proxy host_resolves_to_non_public_ip -- --nocapturecargo test -p codex-network-proxy host_blocked_rejects_allowlisted_hostname_when_dns_lookup_fails -- --nocapturecargo test -p codex-network-proxyjust fmtjust fix -p codex-network-proxygit diff --checkTickets