Tighten marketplace root removal#21120
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5ca8015c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 910e5dd685
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
97cb3cf to
e1ed688
Compare
e1ed688 to
cce7782
Compare
Summary
remove_dir_alland regular file roots withremove_fileWhy
A corrupted marketplace install can leave
CODEX_HOME/.tmp/marketplaces/<name>as a regular file. The remove flow should clean that file up instead of treating the path as directory-only and stopping before the removal outcome is complete.Validation
just fmtcargo test -p codex-core-plugins marketplace_removecargo test -p codex-core-pluginscargo test -p codex-cli --test marketplace_removecargo test -p codex-app-server marketplace_remove -- --nocapturecargo clippy -p codex-core-plugins --all-targets -- -D warningsAfter rebasing onto current
main, reran:cargo test -p codex-core-plugins marketplace_remove