Add turn_id to Codex skill invocation analytics#21122
Merged
edwardysun3 merged 2 commits intomainfrom May 5, 2026
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
rhan-oai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn_idto the Codex skill invocation analytics payloadTrackEventsContextskill_invocationevents include the turn idWhy
chatgpt_skill_resource_invocation/fact_skill_product_eventsalready have backend/schema support forturn_id, but Codex skill invocation events were only sendingthread_id. This caused Codex Desktop skill invocation rows to keepturn_idnull and prevented reliable turn-level joins with artifact/file events.Validation
cargo test -p codex-analytics reducer_ingests_skill_invoked_fact