fix(linux-sandbox): avoid panic on bwrap build failures#21127
Merged
evawong-oai merged 5 commits intomainfrom May 5, 2026
Merged
fix(linux-sandbox): avoid panic on bwrap build failures#21127evawong-oai merged 5 commits intomainfrom
evawong-oai merged 5 commits intomainfrom
Conversation
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
evawong-oai
approved these changes
May 5, 2026
Contributor
evawong-oai
left a comment
There was a problem hiding this comment.
Reviewed the diff and CI. This is scoped to the Linux sandbox panic fix and has regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.codexsymlink inside a writable workspace rootRoot cause
Linux bubblewrap intentionally rejects read-only carveouts that cross a symlink the sandboxed process can still rewrite. That is the correct security behavior for protected metadata paths such as
.codex.The bug was one layer higher:
linux_run_maintreated the expected build failure as impossible and panicked while constructing the bubblewrap argv. For issue #20716, that turned a normal fail-closed sandbox outcome into a noisy panic in the transcript.User impact
Users with a project-local
.codexsymlink inside a writable workspace still get the conservative sandbox decision, but they no longer see a Rust panic for that condition. The helper now exits with the concise sandbox-build error so the normal denial / escalation path can handle it.Fixes #20716