Skip to content

memories-mcp: hide dot paths from list, read, and search#21201

Merged
jif-oai merged 1 commit intomainfrom
jif/hidden-path
May 5, 2026
Merged

memories-mcp: hide dot paths from list, read, and search#21201
jif-oai merged 1 commit intomainfrom
jif/hidden-path

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 5, 2026

Why

The local memories root can contain implementation details such as .git plus incidental OS metadata like .DS_Store. Those entries are not authored memory content, so the memories MCP should keep them invisible instead of exposing them through normal discovery or direct lookup.

Only for local implementation ofc

What changed

  • Return NotFound for scoped list, read, and search requests that include a hidden path component.
  • Skip hidden files and directories while listing a directory or recursively searching the memories tree.
  • Add regression coverage for hidden files, hidden directories, and hidden scoped requests across list, read, and search.

Testing

  • Added focused regression tests in memories/mcp/src/local_tests.rs covering hidden-path behavior across the affected APIs.

@jif-oai jif-oai changed the title feat: hidden path in memories MCP memories-mcp: hide dot paths from list, read, and search May 5, 2026
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 5, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit de924af into main May 5, 2026
26 checks passed
@jif-oai jif-oai deleted the jif/hidden-path branch May 5, 2026 14:59
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant