Skip to content

feat: add normalized matching to memory search#21205

Merged
jif-oai merged 1 commit intomainfrom
jif/normalized-mode
May 5, 2026
Merged

feat: add normalized matching to memory search#21205
jif-oai merged 1 commit intomainfrom
jif/normalized-mode

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 5, 2026

Why

Memory search currently treats separators literally, so callers need to know whether a stored term uses spaces, hyphens, or no separators at all. That makes recall brittle for terms such as MultiAgentV2 vs. multi agent v2 and cold-resume vs. cold resume.

What changed

  • Add an opt-in normalized mode to memory search that removes non-alphanumeric separators after any requested case folding.
  • Thread the new flag through the MCP search tool into the local backend while keeping existing literal matching as the default.
  • Reject queries that normalize to an empty string, and add regression coverage for both normalized matching and that validation path.

Testing

  • cargo test -p codex-memories-mcp

@jif-oai jif-oai changed the title feat: add normalized mode to search feat: add normalized matching to memory search May 5, 2026
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 5, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit be12a80 into main May 5, 2026
26 checks passed
@jif-oai jif-oai deleted the jif/normalized-mode branch May 5, 2026 15:33
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant