Skip to content

app-server: ignore persist_extended_history param#21225

Merged
owenlin0 merged 2 commits intomainfrom
owen/ignore_persist_extended_history
May 5, 2026
Merged

app-server: ignore persist_extended_history param#21225
owenlin0 merged 2 commits intomainfrom
owen/ignore_persist_extended_history

Conversation

@owenlin0
Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 commented May 5, 2026

Why

Taking a step to removing the persistExtendedHistory field. It's not scalable to be persisting so much data in the rollout file and returning it in the thread history.

When a client explicitly sends true, the server now tells that client the parameter is deprecated and ignored so the caller has a clear migration signal via the deprecationNotice notification.

What changed

  • Keep the persist_extended_history / persistExtendedHistory field in the v2 protocol for compatibility, but document it as deprecated and ignored.
  • Ignore the parameter in app-server thread/start, thread/resume, and thread/fork; those paths always use limited history persistence now.
  • Stop treating persistExtendedHistory as a running-thread resume override mismatch.
  • Emit a connection-scoped deprecationNotice when a request explicitly sets persist_extended_history: true.

Verification

  • Added thread_start_deprecates_persist_extended_history_true to cover the deprecation notice.
  • cargo test -p codex-app-server
  • cargo test -p codex-app-server-protocol

@owenlin0 owenlin0 marked this pull request as ready for review May 5, 2026 18:12
@owenlin0 owenlin0 requested a review from pakrym-oai May 5, 2026 18:24
@owenlin0 owenlin0 enabled auto-merge (squash) May 5, 2026 18:26
@owenlin0 owenlin0 merged commit 6075b77 into main May 5, 2026
26 checks passed
@owenlin0 owenlin0 deleted the owen/ignore_persist_extended_history branch May 5, 2026 18:36
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants