app-server: ignore persist_extended_history param#21225
Merged
Conversation
pakrym-oai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Taking a step to removing the
persistExtendedHistoryfield. It's not scalable to be persisting so much data in the rollout file and returning it in the thread history.When a client explicitly sends
true, the server now tells that client the parameter is deprecated and ignored so the caller has a clear migration signal via thedeprecationNoticenotification.What changed
persist_extended_history/persistExtendedHistoryfield in the v2 protocol for compatibility, but document it as deprecated and ignored.thread/start,thread/resume, andthread/fork; those paths always use limited history persistence now.persistExtendedHistoryas a running-thread resume override mismatch.deprecationNoticewhen a request explicitly setspersist_extended_history: true.Verification
thread_start_deprecates_persist_extended_history_trueto cover the deprecation notice.cargo test -p codex-app-servercargo test -p codex-app-server-protocol