Skip to content

add image generation content model#21236

Draft
rhan-oai wants to merge 1 commit intomainfrom
pr21236
Draft

add image generation content model#21236
rhan-oai wants to merge 1 commit intomainfrom
pr21236

Conversation

@rhan-oai
Copy link
Copy Markdown
Collaborator

@rhan-oai rhan-oai commented May 5, 2026

@rhan-oai rhan-oai marked this pull request as draft May 5, 2026 20:55
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 90fda9a423

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

},
{
"properties": {
"content": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Put image content on imageGeneration in schemas

The root JSON schema fixture attaches the new content property to ImageViewThreadItem, while ImageGenerationThreadItem below still lacks it. Regenerating the schemas puts this block under imageGeneration, and cargo test -p codex-app-server-protocol fails with a fixture mismatch. Published schema clients would validate the wrong item shape.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant