Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90fda9a423
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "properties": { | ||
| "content": { |
There was a problem hiding this comment.
Put image content on imageGeneration in schemas
The root JSON schema fixture attaches the new content property to ImageViewThreadItem, while ImageGenerationThreadItem below still lacks it. Regenerating the schemas puts this block under imageGeneration, and cargo test -p codex-app-server-protocol fails with a fixture mismatch. Published schema clients would validate the wrong item shape.
Useful? React with 👍 / 👎.
3432df6 to
5f72413
Compare
Stack created with Sapling. Best reviewed with ReviewStack.