[codex] fix TUI turn items view fixtures#21243
Merged
Conversation
canvrno-oai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the required
items_viewfield to the three session pickerTurntest fixtures that populate full turn item lists.Root Cause
#21063addedTurn.items_viewto the app-server protocol type. The later session picker merge added three test-onlycodex_app_server_protocol::Turnliterals without the new field, which broke Bazel compilation onmainwithE0063: missing field items_view.Validation
just fmtcargo test -p codex-tui resume_picker --no-fail-fastjust argument-comment-lintI also ran
cargo test -p codex-tui; it compiled and ran the suite, but this local machine failed two pre-existing status permission-profile tests because/etc/codex/requirements.tomldisallowsDangerFullAccess.