ci: trigger rusty-v8 releases from tags#21259
Conversation
Swap to tag based releasing and allow tags of type rusty-v8-v*.*.*
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cef1ce37b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "Publishing is only allowed from ${DEFAULT_BRANCH}; current ref is ${GITHUB_REF_NAME}." >&2 | ||
| exit 1 | ||
|
|
||
| - name: Ensure release tag is new |
There was a problem hiding this comment.
The new tag trigger publishes any matching tag without checking that the tag's commit is on the default branch. A tag pushed from an old or side-branch commit with the same v8 version can create the immutable rusty-v8-v<version> release first, producing artifacts that don't match main's checked-in checksum manifest and blocking the correct release.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is the feature we want :)
2 participants
Swap to tag based releasing and allow tags of type
rusty-v8-v*.*.*