Skip to content

[codex] Move thread naming to app server#21260

Merged
pakrym-oai merged 1 commit intomainfrom
pakrym/move-thread-name-to-app-server
May 6, 2026
Merged

[codex] Move thread naming to app server#21260
pakrym-oai merged 1 commit intomainfrom
pakrym/move-thread-name-to-app-server

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Why

Thread names are app-server metadata now, backed by the thread store and sqlite state database. Keeping a core SetThreadName op plus a rollout thread_name_updated event made rename persistence live in the wrong layer and required historical replay support for an event that new app-server flows should not write.

What changed

  • Removed Op::SetThreadName and EventMsg::ThreadNameUpdated from the core protocol and deleted the core handler path that appended rename events to rollouts.
  • Updated app-server thread/name/set so both loaded and unloaded threads write through thread-store metadata and app-server emits thread/name/updated notifications.
  • Updated local thread-store name metadata updates to write sqlite title metadata and the legacy thread-name index without appending rollout events.
  • Removed state extraction and rollout handling for the deleted thread-name event.

Validation

  • cargo test -p codex-app-server thread_name_updated_broadcasts
  • cargo test -p codex-app-server thread_name_set_is_reflected_in_read_list_and_resume
  • cargo test -p codex-thread-store update_thread_metadata_sets_name_on_active_rollout_and_indexes_name
  • cargo test -p codex-state
  • cargo check -p codex-mcp-server -p codex-rollout-trace
  • just fix -p codex-app-server -p codex-thread-store -p codex-state -p codex-mcp-server -p codex-rollout-trace

Docs

No external documentation update is expected for this internal ownership change.

@pakrym-oai pakrym-oai marked this pull request as ready for review May 5, 2026 23:27
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 5, 2026 23:27
@pakrym-oai pakrym-oai force-pushed the pakrym/move-thread-name-to-app-server branch from 96bcac6 to ffcce84 Compare May 5, 2026 23:33
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to clean up app server codepaths to not touch the state DB directly but can be a followup

@pakrym-oai pakrym-oai merged commit 2c1a361 into main May 6, 2026
37 of 38 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/move-thread-name-to-app-server branch May 6, 2026 00:16
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants