[codex] Move thread naming to app server#21260
Merged
pakrym-oai merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
96bcac6 to
ffcce84
Compare
wiltzius-openai
approved these changes
May 5, 2026
Contributor
wiltzius-openai
left a comment
There was a problem hiding this comment.
still need to clean up app server codepaths to not touch the state DB directly but can be a followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Thread names are app-server metadata now, backed by the thread store and sqlite state database. Keeping a core
SetThreadNameop plus a rolloutthread_name_updatedevent made rename persistence live in the wrong layer and required historical replay support for an event that new app-server flows should not write.What changed
Op::SetThreadNameandEventMsg::ThreadNameUpdatedfrom the core protocol and deleted the core handler path that appended rename events to rollouts.thread/name/setso both loaded and unloaded threads write through thread-store metadata and app-server emitsthread/name/updatednotifications.Validation
cargo test -p codex-app-server thread_name_updated_broadcastscargo test -p codex-app-server thread_name_set_is_reflected_in_read_list_and_resumecargo test -p codex-thread-store update_thread_metadata_sets_name_on_active_rollout_and_indexes_namecargo test -p codex-statecargo check -p codex-mcp-server -p codex-rollout-tracejust fix -p codex-app-server -p codex-thread-store -p codex-state -p codex-mcp-server -p codex-rollout-traceDocs
No external documentation update is expected for this internal ownership change.