Move file watcher out of core#21290
Open
pakrym-oai wants to merge 1 commit intopakrym/skills-update-available-app-serverfrom
Open
Move file watcher out of core#21290pakrym-oai wants to merge 1 commit intopakrym/skills-update-available-app-serverfrom
pakrym-oai wants to merge 1 commit intopakrym/skills-update-available-app-serverfrom
Conversation
euroelessar
approved these changes
May 6, 2026
Bojun-Vvibe
added a commit
to Bojun-Vvibe/oss-contributions
that referenced
this pull request
May 6, 2026
- anomalyco/opencode#25959 keep-alive newlines on POST /session/:id/message [merge-after-nits] - anomalyco/opencode#25855 wide-text paste-summary order fix via Intl.Segmenter [merge-after-nits] - openai/codex#21290 extract codex-file-watcher crate from core [merge-after-nits] - openai/codex#21272 add 'compact' SessionStartSource with FIFO queue [merge-after-nits]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app-server watcher relocation leaves the generic filesystem watcher as the last watcher-specific implementation still living inside
codex-core. Moving that code to a small crate keepscodex-corefocused on thread execution and lets app-server depend on the watcher without reaching back into core for filesystem watching primitives.This PR is stacked on #21287.
What changed
codex-file-watchercrate containing the existing watcher implementation and its unit tests.fs_watch,skills_watcher, and listener state to import watcher types fromcodex-file-watcher.file_watchermodule andnotifydependency fromcodex-core.Cargo.lockfor the new internal crate.Validation
cargo check -p codex-file-watcher -p codex-core -p codex-app-servercargo test -p codex-file-watchercargo test -p codex-app-server skills_changed_notification_is_emitted_after_skill_changejust bazel-lock-updatejust bazel-lock-checkjust fix -p codex-file-watcherjust fix -p codex-corejust fix -p codex-app-server