[codex] Add exec-server SIGTERM shutdown#21305
Open
richardopenai wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17de186436
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
17de186 to
c968b85
Compare
starr-openai
approved these changes
May 12, 2026
…term-shutdown # Conflicts: # codex-rs/exec-server/src/remote.rs
…wn' into codex/exec-server-sigterm-shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex exec-serverso the service stops accepting new WebSocket connections and shuts down cleanly.Impact
This makes standalone exec-server behave like a long-lived service when a supervisor or user sends SIGTERM, instead of relying on abrupt process termination.
Validation
just fmtcargo test -p codex-exec-server --test process exec_server_sigterm_shuts_down_gracefullycargo test -p codex-exec-server --test processcargo test -p codex-exec-serverjust fix -p codex-exec-servertarget/debug/codex exec-serverover raw WebSocket: initialize, start a long-running shell process, send SIGTERM to exec-server, verify exit code 0, WebSocket disconnect, and child process cleanup.Notes
just bazel-lock-updateandjust bazel-lock-checkcould not run locally becausebazelis not installed in this environment.