Support PermissionRequest updatedInput rewrites#21391
Closed
abhinav-oai wants to merge 6 commits into
Closed
Conversation
# Conflicts: # codex-rs/core/src/tools/registry.rs
…-input-permission-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This stacks on #20527.
PermissionRequestalso documentsupdatedInput, but unlikePreToolUse, it can participate in approval retries. Supporting it cleanly needs a second layer that can feed rewritten input back through approval evaluation without changing the simpler one-shotPreToolUsepath.What
updatedInputforPermissionRequest, while preserving deny-path validation.PermissionRequestrewrite, with:updatedInputerrors for approval paths that do not have a stable original tool input to rewrite, including deferred network approvals and intercepted exec approvals.PermissionRequestrewrites across shell,apply_patch, and MCP paths.Stack
Base: #20527
Verification
codex-hooksparser coverage forPermissionRequestupdatedInputcodex-corerewrite tests for shell,apply_patch, and MCPPermissionRequestpaths