[codex] Reject full-history spawn overrides#21404
Open
md-oai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes the MultiAgentV2
spawn_agentpath to fail fast when a full-history fork (fork_turns: "all"or an omittedfork_turns) is combined withagent_type,model, orreasoning_effortoverrides.Full-history forks currently inherit the parent thread configuration. That means those child override fields are not applied in that path, which can make a session look like it requested an oracle/model override while the spawned child actually runs with the parent model. The guard turns that silent mismatch into a model-facing error and tells the caller to use
fork_turns: "none"or a positive turn count when child role/model overrides need to apply.The PR also updates the tool schema and root-agent prompt so agents get the rule before they call the tool, and it adjusts the tests that used to assert the old silent-ignore behavior.
Why this is useful
Validation
cargo test -p codex-core multi_agent_v2_spawn -- --nocapturecargo test -p codex-tools spawn_agent_tool_v2_requires_task_name_and_lists_visible_models -- --nocapturecargo test -p codex-core root_agent_prompt_requires_explicit_fork_turns -- --nocapturegit diff --check