[codex-analytics] plumb protocol-native review timing#21434
Draft
[codex-analytics] plumb protocol-native review timing#21434
Conversation
This was referenced May 6, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/analytics/src/reducer.rs
Lines 326 to 328 in f47e6da
Adding completed_at_ms to AnalyticsFact::ServerResponse leaves this match arm non-exhaustive, so codex-analytics no longer compiles (cargo check -p codex-analytics reports E0027). Ignore or bind the new field here before landing.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f47e6da to
b7fda8f
Compare
b7fda8f to
a6a4386
Compare
a6a4386 to
20cbbc4
Compare
562e2d1 to
3b55049
Compare
3b55049 to
a7ac582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We want terminal tool review analytics, but the reducer should not stamp review timing from its own wall clock.
This PR plumbs review timing through the real protocol and app-server seams so the emitter PR can consume those timestamps directly.
What changed
started_at_msto user approval request payloadsstarted_at_ms/completed_at_msto guardian review notificationsServerResponseanalytics facts with app-server-observedcompleted_at_msVerification
cargo test -p codex-app-server outgoing_message --manifest-path codex-rs/Cargo.tomlcargo test -p codex-app-server-protocol guardian --manifest-path codex-rs/Cargo.tomlcargo test -p codex-tui guardian --manifest-path codex-rs/Cargo.tomlcargo test -p codex-analytics analytics_client_tests --manifest-path codex-rs/Cargo.tomlStack created with Sapling. Best reviewed with ReviewStack.