[codex] let later shared reads join a running read window#21525
Open
xli-oai wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing scheduler only formed one batch of leading shared reads, then waited for that whole batch to finish before looking at the queue again. That meant a later
plugin/listarriving behind an already-runningskills/liststill waited even though both requests were safe shared reads.Behavior change
A shared read now joins the active read window immediately when there is no running writer and no queued writer. Exclusive requests still wait for all active reads to finish, and once a writer is queued, later reads stay behind it.
Validation
just fmtjust fix -p codex-app-servercargo test -p codex-app-serversandbox-execcommand-exec tests, one skills watcher timeout, and one websocket-dependent turn interrupt test)plugin/listrequests completed while an earlier longskills/listwas still in flight, which is the behavior this change is intended to enable