Add managed hook suppression#21577
Closed
abhinav-oai wants to merge 1 commit intomainfrom
Closed
Conversation
9a2cf45 to
b1dec90
Compare
b1dec90 to
1b164ba
Compare
eternal-openai
requested changes
May 7, 2026
Contributor
eternal-openai
left a comment
There was a problem hiding this comment.
Hey I know I'm reviewing this too early since it's still a draft, but there are some issues:
- the mechanism of just dropping the notifications doesn't really work, as elegant as that would be. consider the case where the hooks still blocks or crashes - the UI would need to then make what happened visible, rather than just stopping the thread without explanation. there's probably other things that still need visual treatment, like stop-block continuation prompts originating from hidden hooks
- so we actually do need to thread hook visibility through the notifications, and just have the UIs decide to hide them more intelligently
- some of the renames here feel like a bit more churn than is necessary
- i think the naming could be better. How about something like
visibility_hint: "default" | "hidden"? my concern is that the current naming overlaps too much with the spec'ssuppressOutputwhich means something different
Collaborator
Author
hmm that's a great point
another idea that could be interesting is exposing as part of normal config but still have requirements clamp the value. I think normal users would also like this config as I've seen a few related issuesL
will also take a pass and clean it up overall! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Managed hooks from requirements can be intentionally noisy when they run every turn, and the current runtime always surfaces their lifecycle notifications to clients. We want admins to be able to suppress only those managed hook notifications without giving user config a way to hide local/plugin hooks.
What
suppressfield for command hookssuppressappears in user hook config by ignoring it and emitting a warninghook/started+hook/completednotifications for suppressed runs while still recording metrics/analytics