Fix /review mode MCP startup render issue#21624
Conversation
canvrno-oai
force-pushed
the
canvrno/thread-scoped-mcp-startup-status
branch
3 times, most recently
from
9d62088 to
f0d10cd
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1293af76f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
canvrno-oai
changed the title
canvrno-oai
force-pushed
the
canvrno/thread-scoped-mcp-startup-status
branch
2 times, most recently
from
ac02b28 to
a5f2dbf
Compare
canvrno-oai
changed the title
canvrno-oai
force-pushed
the
canvrno/thread-scoped-mcp-startup-status
branch
from
a5f2dbf to
d0f928b
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0f928ba13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
canvrno-oai
force-pushed
the
canvrno/thread-scoped-mcp-startup-status
branch
from
d0f928b to
43a4877
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Tested locally with the happy path of an isolated codex home and a slow MCP server. Tried a /review and while the MCP startup was pending it showed Starting MCP servers (0/2): codex_apps, smoke_slow_ready.
After settled, the review was still running and didn't get stuck.
Code looks good, approved. 👍
2 participants
This change fixes the case where the UI can sit on "Starting MCP servers" even though the review work is already running or has already completed.
/reviewturn starts with enabled MCP server startupsDe-scoped from a broader thread-scoped MCP status change that would have made it easier to route MCP startup statuses to the appropriate thread (parent vs. review). These changes address the UI regression without requiring more significant changes across app-server & core.
Fixes #18792.