[codex] Enable apply_patch freeform by default#21687
Conversation
Co-authored-by: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e53d9c8e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stage: Stage::UnderDevelopment, | ||
| default_enabled: false, | ||
| stage: Stage::Stable, | ||
| default_enabled: true, |
There was a problem hiding this comment.
Setting this feature on by default makes every model whose apply_patch_tool_type is None get a freeform grammar tool via ToolsConfig::new's None => ...Freeform branch. Catalog entries such as Bedrock GPT-OSS still use None, and the JSON apply_patch tool is documented as the GPT-OSS-compatible path, so those sessions will now send an unsupported freeform tool unless explicitly disabled.
Useful? React with 👍 / 👎.
Co-authored-by: Codex <noreply@openai.com>
2 participants
Summary
apply_patch_freeformby default in the feature registryWhy
apply_patchtool available by default when model metadata does not explicitly opt into another modeValidation
just fmt