Skip to content

extension: wire extension registries into sessions#21737

Merged
jif-oai merged 3 commits into
mainfrom
jif/extension-wiring
May 11, 2026
Merged

extension: wire extension registries into sessions#21737
jif-oai merged 3 commits into
mainfrom
jif/extension-wiring

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 8, 2026

Why

#21736 introduces the typed extension API, but the runtime does not yet carry a registry through thread/session startup or give contributors host-owned stores to read from. This PR wires that host-side path so later feature migrations can move product-specific behavior behind typed contributions without adding another bespoke seam directly to codex-core.

What changed

  • Thread ExtensionRegistry<Config> through ThreadManager, CodexSpawnArgs, Session, and sub-agent spawn paths.
  • Wire ThreadStartContributor and ContextContributor
  • Expose the small supporting surface needed by non-core callers that construct threads directly, including empty_extension_registry() through codex-core-api.

This PR lands the host plumbing only: the app-server registry is still empty, and concrete feature migrations are intended to follow separately.

@jif-oai jif-oai requested a review from a team as a code owner May 8, 2026 12:45
struct GitAttributionTestContributor;
struct GitAttributionTestState;

impl codex_extension_api::ContextContributor for GitAttributionTestContributor {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a merge artifact and it will disappear

@jif-oai jif-oai changed the title extension: wire extension registries extension: wire extension registries into sessions May 8, 2026
Base automatically changed from jif/extension-api to main May 11, 2026 09:06
@jif-oai jif-oai merged commit 436c0df into main May 11, 2026
29 checks passed
@jif-oai jif-oai deleted the jif/extension-wiring branch May 11, 2026 09:38
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant