extension: wire extension registries into sessions#21737
Merged
Conversation
jif-oai
commented
May 8, 2026
| struct GitAttributionTestContributor; | ||
| struct GitAttributionTestState; | ||
|
|
||
| impl codex_extension_api::ContextContributor for GitAttributionTestContributor { |
Collaborator
Author
There was a problem hiding this comment.
This is a merge artifact and it will disappear
a57a747 to
2eb48e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#21736 introduces the typed extension API, but the runtime does not yet carry a registry through thread/session startup or give contributors host-owned stores to read from. This PR wires that host-side path so later feature migrations can move product-specific behavior behind typed contributions without adding another bespoke seam directly to
codex-core.What changed
ExtensionRegistry<Config>throughThreadManager,CodexSpawnArgs,Session, and sub-agent spawn paths.ThreadStartContributorandContextContributorempty_extension_registry()throughcodex-core-api.This PR lands the host plumbing only: the app-server registry is still empty, and concrete feature migrations are intended to follow separately.