Improve hooks trust flow in TUI#21755
Merged
Merged
Conversation
abhinav-oai
changed the title
fcoury-oai
approved these changes
May 8, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
The flow looks and feels really good.
Code also looks good, approved! 👍
# Conflicts: # codex-rs/tui/src/bottom_pane/hooks_browser_view.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hooks that need trust review were easy to miss, and the existing TUI flow made users discover
/hooksmanually before they could decide whether to inspect or trust them.What
tshortcut in/hooksto trust every review-needed hook at onceTUI
Startup review interstitial
Top-level
/hookspage when review is needed