Conversation
ww-oai
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR CI should test the exact commit that was pushed to the PR branch. By default, GitHub's
pull_requestevent checks out a synthetic merge commit fromrefs/pull/<number>/merge, so the tested tree can include an implicit merge with the current base branch instead of matching the pushed head SHA.Using the PR head SHA makes each check result correspond to a concrete commit the author submitted. This also behaves better for stacked PR workflows, including Sapling stacks and other Git stack tooling: a middle PR's head commit already contains the lower stack changes in its tree, without pulling in commits above it or GitHub's temporary merge ref.
What Changed
actions/checkoutinpull_requestworkflows under.github/workflowsto usegithub.event.pull_request.head.shaon PR events andgithub.shaotherwise.blob-size-policyto comparegithub.event.pull_request.base.shaandgithub.event.pull_request.head.sha, since it no longer checks out GitHub's merge commit whereHEAD^1/HEAD^2represented the PR range.Verification
pull_requestworkflows has the PR-headref.