Apply sandbox context to local view_image reads#21861
Merged
Merged
Conversation
pakrym-oai
reviewed
May 11, 2026
| ); | ||
| } | ||
|
|
||
| #[tokio::test] |
Collaborator
There was a problem hiding this comment.
can we add an integration test instead?
Contributor
Author
There was a problem hiding this comment.
added. imo having unit test equivalents is nice too - so I left this
pakrym-oai
requested changes
May 11, 2026
starr-openai
added a commit
that referenced
this pull request
May 11, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai
added a commit
that referenced
this pull request
May 11, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai
added a commit
that referenced
this pull request
May 11, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai
added a commit
that referenced
this pull request
May 11, 2026
Co-authored-by: Codex <noreply@openai.com>
starr-openai
added a commit
that referenced
this pull request
May 11, 2026
Co-authored-by: Codex <noreply@openai.com>
Create a selected-cwd filesystem sandbox context for view_image metadata and file reads regardless of whether the selected environment is local or remote. Add a local restricted-profile regression test for the previously unsandboxed read path. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
starr-openai
force-pushed
the
starr/view-image-sandbox-20260508
branch
from
0f3c454 to
722a98c
Compare
pakrym-oai
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation