Skip to content

Persist 'priority' service tier as fast in config#21991

Merged
aibrahim-oai merged 1 commit into
mainfrom
codex/save-priority-as-fast-in-config
May 10, 2026
Merged

Persist 'priority' service tier as fast in config#21991
aibrahim-oai merged 1 commit into
mainfrom
codex/save-priority-as-fast-in-config

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

Motivation

  • Normalize persisted service tier so selecting the request value priority (or legacy fast) is stored as fast while preserving unknown tier IDs and keeping request-time behavior unchanged.

Description

  • Update persistence logic in codex-rs/core/src/config/edit.rs so ConfigEdit::SetServiceTier maps request values: priority/fast -> "fast", flex -> "flex", and leaves unknown strings unchanged.
  • Add unit tests in codex-rs/core/src/config/edit_tests.rs that verify a priority selection is written to config.toml as "fast" and that unknown tiers are preserved.
  • Add a config load test in codex-rs/core/src/config/config_tests.rs to ensure service_tier = "priority" still resolves to the priority request value at load time.
  • Add the required import use codex_protocol::config_types::ServiceTier; to the edited modules.

Testing

  • Ran just fmt and just fix -p codex-core to apply formatting and lints and they completed successfully.
  • Ran cargo test -p codex-core --lib service_tier (focused unit tests for the change) and the tests passed.
  • Ran cargo test -p codex-protocol and the protocol test suite passed.
  • Note: an initial broader cargo test -p codex-core service_tier invocation matched integration tests and produced unrelated failures/hangs, so that run was interrupted and the focused --lib unit-test invocation was used instead.

Codex Task

@aibrahim-oai aibrahim-oai added the codex Label used by connector to tag PRs that have been reviewed by Codex label May 10, 2026 — with ChatGPT Codex Connector
@aibrahim-oai aibrahim-oai requested a review from a team as a code owner May 10, 2026 02:23
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aibrahim-oai aibrahim-oai merged commit 178c3d3 into main May 10, 2026
26 checks passed
@aibrahim-oai aibrahim-oai deleted the codex/save-priority-as-fast-in-config branch May 10, 2026 03:22
@github-actions github-actions Bot locked and limited conversation to collaborators May 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

codex Label used by connector to tag PRs that have been reviewed by Codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants