Persist 'priority' service tier as fast in config#21991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
priority(or legacyfast) is stored asfastwhile preserving unknown tier IDs and keeping request-time behavior unchanged.Description
codex-rs/core/src/config/edit.rssoConfigEdit::SetServiceTiermaps request values:priority/fast->"fast",flex->"flex", and leaves unknown strings unchanged.codex-rs/core/src/config/edit_tests.rsthat verify apriorityselection is written toconfig.tomlas"fast"and that unknown tiers are preserved.codex-rs/core/src/config/config_tests.rsto ensureservice_tier = "priority"still resolves to thepriorityrequest value at load time.use codex_protocol::config_types::ServiceTier;to the edited modules.Testing
just fmtandjust fix -p codex-coreto apply formatting and lints and they completed successfully.cargo test -p codex-core --lib service_tier(focused unit tests for the change) and the tests passed.cargo test -p codex-protocoland the protocol test suite passed.cargo test -p codex-core service_tierinvocation matched integration tests and produced unrelated failures/hangs, so that run was interrupted and the focused--libunit-test invocation was used instead.Codex Task