Skip to content

Fix side conversation config inheritance#22106

Merged
etraut-openai merged 2 commits into
mainfrom
etraut/side-inherit-parent-config
May 11, 2026
Merged

Fix side conversation config inheritance#22106
etraut-openai merged 2 commits into
mainfrom
etraut/side-inherit-parent-config

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented May 11, 2026

Addresses #22101

Why

Side conversations are ephemeral forks of the active thread, but /side was building its fork config from the app-level config after refreshing it from disk. If the parent thread had runtime settings that differed from the current persisted defaults, such as a changed model, reasoning effort, permissions, reviewer, or fast-mode selection, the side conversation could start with different behavior than its parent.

What changed

  • Build side fork config from the active parent ChatWidget config, then overlay the parent thread's effective model, reasoning effort, service tier, and fast-mode opt-out state.
  • Forward model reasoning summary, verbosity, personality, web search mode, and service-tier overrides through TUI app-server start/resume/fork lifecycle params.
  • Add focused tests for parent runtime inheritance, side developer guardrail preservation, and lifecycle param forwarding.

Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared a finding from Codex for your consideration, other than that looks good.

I tested it by changing the model and reasoning on ~/.codex/config.toml after a session had started but before sending /side and it inherited the session settings, not what was in the config.

Comment thread codex-rs/tui/src/app_server_session.rs Outdated
@etraut-openai etraut-openai merged commit c03eb20 into main May 11, 2026
26 checks passed
@etraut-openai etraut-openai deleted the etraut/side-inherit-parent-config branch May 11, 2026 16:47
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants