Skip to content

TUI: Pause queue sends after usage limits#22225

Open
ee-oai wants to merge 4 commits into
ee/pause-queue-sends-corefrom
ee/pause-queue-sends-tui
Open

TUI: Pause queue sends after usage limits#22225
ee-oai wants to merge 4 commits into
ee/pause-queue-sends-corefrom
ee/pause-queue-sends-tui

Conversation

@ee-oai
Copy link
Copy Markdown

@ee-oai ee-oai commented May 11, 2026

Stacked on #22226.

The TUI freezes queued sends after usage-limit exhaustion, surfaces that paused state in the pending-input preview, and requires explicit resume confirmation before the queue continues. The resume hint now matches the actual Enter behavior when the composer is empty.

The local mock Responses websocket scenario remains available for end-to-end manual validation of the paused queue flow.

Validation:

  • cargo test -p codex-tui render_paused_
  • cargo test -p codex-tui paused_queued_sends_require_confirmation_before_resuming

Screenshots

Screenshot 2026-05-12 at 8 03 45 AM Screenshot 2026-05-12 at 8 03 49 AM

@ee-oai ee-oai force-pushed the ee/pause-queue-sends-tui branch from 43613ce to c4b9206 Compare May 11, 2026 23:18
@ee-oai ee-oai force-pushed the ee/pause-queue-sends-core branch from 71ef1ef to cfd454b Compare May 11, 2026 23:27
@ee-oai ee-oai requested a review from a team as a code owner May 11, 2026 23:27
@ee-oai ee-oai force-pushed the ee/pause-queue-sends-tui branch from c4b9206 to 6f477ca Compare May 11, 2026 23:44
Co-authored-by: Codex <noreply@openai.com>
@ee-oai ee-oai force-pushed the ee/pause-queue-sends-core branch from cfd454b to 5880fd7 Compare May 11, 2026 23:51
@ee-oai ee-oai force-pushed the ee/pause-queue-sends-tui branch 2 times, most recently from ee66f62 to b38f369 Compare May 12, 2026 01:13
Co-authored-by: Codex <noreply@openai.com>
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test the paused queued-send flow with the local mock Responses websocket scenario.

Code looks good. Found two potential issues. Let me know if you want to address them.

Comment thread codex-rs/tui/src/chatwidget/queued_sends.rs
Comment thread codex-rs/tui/src/bottom_pane/pending_input_preview.rs
@etraut-openai
Copy link
Copy Markdown
Collaborator

I think this change will cause the TUI to deviate from the behavior of the other Codex surfaces. Are there plans to change the app to match this behavior too?

@ee-oai
Copy link
Copy Markdown
Author

ee-oai commented May 14, 2026

I think this change will cause the TUI to deviate from the behavior of the other Codex surfaces. Are there plans to change the app to match this behavior too?

Yes, see https://github.com/openai/openai/pull/900729

@ee-oai ee-oai force-pushed the ee/pause-queue-sends-tui branch from 6ad8446 to 73431e9 Compare May 14, 2026 13:29
@ee-oai ee-oai force-pushed the ee/pause-queue-sends-tui branch from 73431e9 to 236fa42 Compare May 14, 2026 13:32
@ee-oai ee-oai requested a review from fcoury-oai May 14, 2026 13:33
@ee-oai ee-oai force-pushed the ee/pause-queue-sends-core branch from 5880fd7 to cdfd8c6 Compare May 14, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants