Expose plugin provenance for listed skills#22228
Draft
nm-openai wants to merge 1 commit into
Draft
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillProvenanceplus optional plugin metadata toskills/listso clients can distinguish personal/project/system/admin skills from marketplace/local/debug/ad-hoc plugin skills.scopefield unchanged as the skill placement/precedence contract.display_name,brand_color,composer_icon,logo) from plugin load outcomes into listed skill metadata.Scope vs Provenance Logic
scopecontinues to mean where the skill participates in existing skill semantics:Usermaps to legacyPersonalUI behavior.Repomaps to project/repo-root UI behavior, such as renderingcodexfor/Users/nm/code/codex.Systemmaps to built-in system skills.Adminmaps to system-config/admin-installed skills.provenancefromscope:Personal,Project,System, orAdmin.scopevalue, usuallyUser, so ordering and compatibility do not change.pluginmetadata and plugin-specificprovenancederived from marketplace name:openai-curatedandchatgpt-global->OpenaiMarketplaceWorkspaceMarketplacedebug->DebugPluginlocal/personal->LocalPluginCustomMarketplacescopewith provenance while giving newer clients enough data to render plugin origin, icon fallback, and brand color.Compatibility
scope-based labels and existing icon behavior whenprovenance/pluginare absent.scopeenum and behavior; plugin skills are not sent as newscopevalues.Paired PR
Paired Codex app UI PR: openai/openai#911245. The UI PR consumes the new fields to render provenance labels, plugin icon fallback, and plugin brand-color highlighting. These should merge together, with this app-server PR providing the protocol/payload shape.
Test Plan
just write-app-server-schemacargo test -p codex-app-server-protocolcargo test -p codex-app-server skills_listjust fix -p codex-app-server -p codex-app-server-protocol -p codex-core-plugins -p codex-plugin