fix(tui): render network approval history by target#22229
Conversation
3a9e513 to
e70dbbf
Compare
e70dbbf to
ef13220
Compare
|
When testing this, the action being performed is not rendered in the message following my approval. Examples:
|
Thanks for catching this. I found a fallback path where the approval history could still render an empty command subject, which produced the Pushed d3797e1 to handle that case by rendering a generic Would you mind doing another pass at your convenience? Thx again. |
d3797e1 to
e2db9bb
Compare
canvrno-oai
left a comment
There was a problem hiding this comment.
Tested with the latest changes, looks good!
Why
Network approval prompts are rendered without a command string on the app-server path. After the user approves one of those prompts, the TUI history cell previously fell back to command-oriented copy and produced malformed lines such as:
That hid the network target the user actually approved and left a visibly broken transcript entry.
What changed
network-accesstarget when present, including non-default ports such ashttps://example.com:8443.protocol://hostwhen no generated target command is available.How to Test
You approved codex network access to https://example.com:8443 every time this sessionTargeted automated coverage:
cargo test -p codex-tui network_exec_approval_historyAdditional verification
cargo insta pending-snapshotsgit diff --checkjust fix -p codex-tuijust argument-comment-lintKnown unrelated local test noise
A full
cargo test -p codex-tuirun still hits a pre-existing stack overflow outside this change:tests::fork_last_filters_latest_session_by_cwd_unless_show_allaborts with a stack overflow