[codex] Filter legacy warning messages during compaction#22243
Merged
Conversation
pakrym-oai
force-pushed
the
pakrym/filter-unified-exec-warning-compaction
branch
from
650c2ac to
368d9c0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 368d9c0713
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sayan-oai
reviewed
May 12, 2026
sayan-oai
approved these changes
May 12, 2026
pakrym-oai
force-pushed
the
pakrym/filter-unified-exec-warning-compaction
branch
from
368d9c0 to
fd9dee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Older sessions can contain model-warning records persisted as
usermessages, including the unified exec process-limit warning, theapply_patch-via-exec_commandwarning, and the model-mismatch high-risk cyber fallback warning. Those warnings are no longer produced as conversation history items, but when old sessions compact they should still be recognized as injected context rather than preserved as real user turns.What changed
record_model_warningand the production paths that emitted these warning messages into conversation history.LegacyUnifiedExecProcessLimitWarning,LegacyApplyPatchExecCommandWarning, andLegacyModelMismatchWarningcontextual fragments that are used only for matching old persisted messages.Testing
cargo test -p codex-core warningjust fix -p codex-core