[codex] Remove unused legacy shell tools#22246
Merged
pakrym-oai merged 11 commits intoMay 13, 2026
Merged
Conversation
pakrym-oai
changed the title
…hell-container-exec-tools # Conflicts: # codex-rs/core/src/tools/handlers/shell.rs # codex-rs/core/src/tools/handlers/shell/container_exec.rs # codex-rs/core/src/tools/handlers/shell/local_shell.rs # codex-rs/core/src/tools/handlers/shell/shell_handler.rs
…hell-container-exec-tools # Conflicts: # codex-rs/core/src/tools/handlers/shell/container_exec.rs # codex-rs/core/src/tools/handlers/shell/local_shell.rs # codex-rs/core/src/tools/handlers/shell/shell_handler.rs # codex-rs/core/src/tools/router.rs # codex-rs/core/src/tools/spec_plan.rs
Collaborator
Author
|
@codex review this |
dylan-hurd-oai
approved these changes
May 13, 2026
…hell-container-exec-tools # Conflicts: # codex-rs/core/src/function_tool.rs # codex-rs/core/src/tools/context.rs # codex-rs/core/src/tools/handlers/shell/container_exec.rs # codex-rs/core/src/tools/handlers/shell/local_shell.rs # codex-rs/core/src/tools/handlers/shell/shell_handler.rs # codex-rs/core/src/tools/router.rs # codex-rs/core/tests/suite/tools.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recent session history showed no active use of the raw
shell,local_shell, orcontainer.execexecution surfaces. Keeping those handlers/specs wired into core leaves duplicate shell execution paths alongside the supportedshell_commandand unified exec tools.What changed
shellhandler/spec and itsShellToolCallParamsprotocol helper.local_shellandcontainer.exechandler/spec plumbing while preserving persisted-history compatibility for old response items.defaultandlocalshell selections toshell_command.shell_command, unified exec, and freeformapply_patch.Verification
git diff --checkcargo test -p codex-protocolcargo test -p codex-toolscargo test -p codex-core tools::handlers::shellcargo test -p codex-core tools::speccargo test -p codex-core tools::routercargo test -p codex-core active_call_preserves_triggering_command_contextcargo test -p codex-core guardian_testscargo test -p codex-core --test all shell_serializationcargo test -p codex-core --test all apply_patch_clicargo test -p codex-core --test all shell_command_cargo test -p codex-core --test all local_shellcargo test -p codex-core --test all otel::cargo test -p codex-core --test all hooks::just fix -p codex-corejust fix -p codex-tools