Skip to content

[codex] cover code mode app file uploads#22285

Draft
lt-oai wants to merge 1 commit into
mainfrom
codex/file-broker-p0-1-code-mode-regression
Draft

[codex] cover code mode app file uploads#22285
lt-oai wants to merge 1 commit into
mainfrom
codex/file-broker-p0-1-code-mode-regression

Conversation

@lt-oai
Copy link
Copy Markdown
Contributor

@lt-oai lt-oai commented May 12, 2026

What

  • Adds an integration test for the current Code Mode nested MCP path with openai/fileParams.
  • Verifies a local file argument is uploaded and rewritten before the Codex Apps tool call.

Why

  • Locks down the backward-compatible upload path before changing the file broker implementation.
  • Confirms Code Mode routes tools.mcp__... calls through the same file upload bridge as normal MCP calls.

How

  • Uses the existing Codex Apps test server and mocked OpenAI file upload endpoints.
  • Asserts the downstream Apps tools/call receives the rewritten file reference payload.

Validation

  • cargo test -p codex-core --test all code_mode_nested_mcp_file_params_upload_local_paths_before_tool_call -- --nocapture

Add integration coverage that exercises Code Mode's nested MCP tool path through openai/fileParams rewriting for Codex Apps file uploads.

Co-authored-by: Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant