[codex] accept env file refs for app uploads#22288
Draft
lt-oai wants to merge 1 commit into
Draft
Conversation
Allow openai/fileParams arguments to use env://current/<relative-path> references, resolving them through the file broker before uploading to OpenAI file storage. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
openai/fileParamsarguments to useenv://current/<relative-path>file references.Why
How
env://currentrefs.env://...environments, empty paths, absolute env paths, and cwd escapes.Validation
cargo test -p codex-core mcp_openai_file -- --nocapturecargo test -p codex-mcp tools -- --nocapturecargo test -p codex-core --test all codex_apps_file_params_upload_local_paths_before_mcp_tool_call -- --nocapture