Skip to content

chore: Keep view_image sandbox test in temp dir#22355

Merged
jif-oai merged 2 commits into
mainfrom
codex/view-image-test-temp-cwd
May 13, 2026
Merged

chore: Keep view_image sandbox test in temp dir#22355
jif-oai merged 2 commits into
mainfrom
codex/view-image-test-temp-cwd

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 12, 2026

Summary

  • move the view_image sandbox filesystem-read unit test onto a temporary cwd
  • keep the turn cwd and selected turn environment cwd aligned inside the test
  • avoid leaving core/image.png behind in the repo checkout after the test runs

Root cause

The test wrote image.png beneath turn.cwd, and the shared session test helper defaults that cwd to the current repo directory when no override is provided.

Validation

  • just fmt
  • cargo test -p codex-core tools::handlers::view_image::tests::handle_passes_sandbox_context_for_local_filesystem_reads

@jif-oai jif-oai marked this pull request as ready for review May 12, 2026 17:54
@jif-oai jif-oai requested a review from a team as a code owner May 12, 2026 17:54
@jif-oai jif-oai changed the title [codex] Keep view_image sandbox test in temp dir chore: Keep view_image sandbox test in temp dir May 12, 2026
@jif-oai jif-oai merged commit 7e97da7 into main May 13, 2026
27 checks passed
@jif-oai jif-oai deleted the codex/view-image-test-temp-cwd branch May 13, 2026 08:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants