Skip to content

mark Feature::RemoteControl as removed#22386

Merged
owenlin0 merged 1 commit into
mainfrom
owen/ignore_remote_control_feature
May 13, 2026
Merged

mark Feature::RemoteControl as removed#22386
owenlin0 merged 1 commit into
mainfrom
owen/ignore_remote_control_feature

Conversation

@owenlin0
Copy link
Copy Markdown
Collaborator

@owenlin0 owenlin0 commented May 12, 2026

Why

remote_control can appear in config.toml, CLI feature overrides, and the app-server config APIs. Before this PR, app-server startup treated config.features.enabled(Feature::RemoteControl) as the signal to start remote control (base code). That meant a user with:

[features]
remote_control = true

would accidentally opt every app-server process into remote control. Remote-control startup should instead be a per-process launch decision made by CLI flags.

What Changed

  • Marks Feature::RemoteControl as Stage::Removed, keeping remote_control as a known compatibility key while making it config-inert.
  • Adds a hidden --remote-control process flag to codex app-server and standalone codex-app-server.
  • Plumbs that flag through AppServerRuntimeOptions.remote_control_enabled and makes app-server startup use only that runtime option to decide whether to start remote control.
  • Removes the app-server config mutation hook that reloaded config and toggled remote control at runtime.
  • Updates managed daemon spawning to use codex app-server --remote-control --listen unix:// instead of --enable remote_control.

Config APIs can still list, read, write, and set remote_control; those operations just no longer affect remote-control process enrollment.

@owenlin0 owenlin0 force-pushed the owen/ignore_remote_control_feature branch from ee534d6 to 7a510a1 Compare May 12, 2026 22:26
@owenlin0 owenlin0 changed the title ignore Feature::RemoteControl Make app-server remote control process opt-in May 12, 2026
@owenlin0 owenlin0 force-pushed the owen/ignore_remote_control_feature branch from 7a510a1 to adbe3be Compare May 12, 2026 22:29
@owenlin0 owenlin0 changed the title Make app-server remote control process opt-in mark Feature::RemoteControl as removed May 12, 2026
@owenlin0 owenlin0 marked this pull request as ready for review May 12, 2026 22:30
@owenlin0 owenlin0 enabled auto-merge (squash) May 12, 2026 22:37
@owenlin0 owenlin0 force-pushed the owen/ignore_remote_control_feature branch from adbe3be to 408a3b3 Compare May 13, 2026 00:28
@owenlin0 owenlin0 merged commit 2237a13 into main May 13, 2026
27 checks passed
@owenlin0 owenlin0 deleted the owen/ignore_remote_control_feature branch May 13, 2026 00:52
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants