mark Feature::RemoteControl as removed#22386
Merged
Merged
Conversation
ee534d6 to
7a510a1
Compare
7a510a1 to
adbe3be
Compare
apanasenko-oai
approved these changes
May 12, 2026
adbe3be to
408a3b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
remote_controlcan appear inconfig.toml, CLI feature overrides, and the app-server config APIs. Before this PR, app-server startup treatedconfig.features.enabled(Feature::RemoteControl)as the signal to start remote control (base code). That meant a user with:would accidentally opt every app-server process into remote control. Remote-control startup should instead be a per-process launch decision made by CLI flags.
What Changed
Feature::RemoteControlasStage::Removed, keepingremote_controlas a known compatibility key while making it config-inert.--remote-controlprocess flag tocodex app-serverand standalonecodex-app-server.AppServerRuntimeOptions.remote_control_enabledand makes app-server startup use only that runtime option to decide whether to start remote control.codex app-server --remote-control --listen unix://instead of--enable remote_control.Config APIs can still list, read, write, and set
remote_control; those operations just no longer affect remote-control process enrollment.