test(tui): relax configured pet load timeout#22392
Merged
Merged
Conversation
canvrno-oai
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows CI has been timing out in
configured_pet_load_is_deferred_until_after_constructionwhile waiting for the deferred configured-pet load event.The test still needs to prove construction returns before the pet image is available, but the background load slices the built-in pet spritesheet into frame cache files. That work can exceed the old 2 second deadline on slower or more contended CI machines.
What Changed
ConfiguredPetLoadedfrom 2 seconds to 30 seconds.ChatWidgetconstruction.How to Test
Targeted tests:
cargo test -p codex-tui configured_pet_load_is_deferred_until_after_constructionjust argument-comment-lintAdditional check:
cargo test -p codex-tuiwas run, but the broader crate suite did not complete successfully due to unrelated existing failures:status::tests::status_permissions_full_disk_managed_without_network_is_external_sandboxstatus::tests::status_permissions_full_disk_managed_with_network_is_danger_full_accesstests::fork_last_filters_latest_session_by_cwd_unless_show_allfrom stack overflow