Skip to content

test(tui): relax configured pet load timeout#22392

Merged
bolinfest merged 1 commit into
mainfrom
fcoury/fix-win-pet-tests
May 12, 2026
Merged

test(tui): relax configured pet load timeout#22392
bolinfest merged 1 commit into
mainfrom
fcoury/fix-win-pet-tests

Conversation

@fcoury-oai
Copy link
Copy Markdown
Contributor

Why

Windows CI has been timing out in configured_pet_load_is_deferred_until_after_construction while waiting for the deferred configured-pet load event.

The test still needs to prove construction returns before the pet image is available, but the background load slices the built-in pet spritesheet into frame cache files. That work can exceed the old 2 second deadline on slower or more contended CI machines.

What Changed

  • Increased the test wait for ConfiguredPetLoaded from 2 seconds to 30 seconds.
  • Kept the post-construction assertion intact so the test still verifies that the pet is not loaded synchronously during ChatWidget construction.

How to Test

Targeted tests:

  • cargo test -p codex-tui configured_pet_load_is_deferred_until_after_construction
  • just argument-comment-lint

Additional check:

  • cargo test -p codex-tui was run, but the broader crate suite did not complete successfully due to unrelated existing failures:
    • status::tests::status_permissions_full_disk_managed_without_network_is_external_sandbox
    • status::tests::status_permissions_full_disk_managed_with_network_is_danger_full_access
    • later abort in tests::fork_last_filters_latest_session_by_cwd_unless_show_all from stack overflow

@bolinfest bolinfest merged commit 6dc3b3d into main May 12, 2026
27 checks passed
@bolinfest bolinfest deleted the fcoury/fix-win-pet-tests branch May 12, 2026 23:50
@github-actions github-actions Bot locked and limited conversation to collaborators May 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants