[codex] Add search term coverage for tool_search#22398
Merged
Merged
Conversation
sayan-oai
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tool_searchalready had solid end-to-end coverage for discovery and follow-up execution, but it did not prove that distinct pieces of indexed search text actually work in integration. In particular, we were not exercising whether unique tool names, descriptions, namespaces, underscore-expanded dynamic names, and schema-property terms were sufficient to surface the expected deferred tools.This change adds focused integration coverage for those term sources so regressions in search text construction are caught by a real
TestCodexflow instead of only by lower-level unit tests.What changed
core/tests/suite/search_tool.rsto assert that atool_search_outputcontains an expected namespace child tooltool_search_calls and verifies distinct query terms match the expected app tools:calendar_timezone_option_99uploaded documentstarts_atquasar_ping_beaconquasar ping beaconsaffron metronomeorbit_opschrono_specValidation
cargo test -p codex-core tool_search_matches_Docs
No documentation update needed.