Skip to content

[codex] Add search term coverage for tool_search#22398

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/tool-search-term-coverage
May 13, 2026
Merged

[codex] Add search term coverage for tool_search#22398
pakrym-oai merged 1 commit into
mainfrom
pakrym/tool-search-term-coverage

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Why

tool_search already had solid end-to-end coverage for discovery and follow-up execution, but it did not prove that distinct pieces of indexed search text actually work in integration. In particular, we were not exercising whether unique tool names, descriptions, namespaces, underscore-expanded dynamic names, and schema-property terms were sufficient to surface the expected deferred tools.

This change adds focused integration coverage for those term sources so regressions in search text construction are caught by a real TestCodex flow instead of only by lower-level unit tests.

What changed

  • added a small helper in core/tests/suite/search_tool.rs to assert that a tool_search_output contains an expected namespace child tool
  • added an MCP integration test that issues several tool_search_calls and verifies distinct query terms match the expected app tools:
    • exact tool name: calendar_timezone_option_99
    • tool description phrase: uploaded document
    • top-level schema property: starts_at
  • added a dynamic-tool integration test that verifies distinct query terms match the expected deferred dynamic tool:
    • exact name: quasar_ping_beacon
    • underscore-expanded name: quasar ping beacon
    • description phrase: saffron metronome
    • namespace: orbit_ops
    • schema property: chrono_spec

Validation

  • cargo test -p codex-core tool_search_matches_

Docs

No documentation update needed.

@pakrym-oai pakrym-oai marked this pull request as ready for review May 13, 2026 00:12
@pakrym-oai pakrym-oai requested a review from a team as a code owner May 13, 2026 00:12
@pakrym-oai pakrym-oai enabled auto-merge (squash) May 13, 2026 00:16
@pakrym-oai pakrym-oai merged commit f11ad1e into main May 13, 2026
27 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/tool-search-term-coverage branch May 13, 2026 00:24
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants