Skip to content

Make context contributors async#22491

Merged
jif-oai merged 2 commits into
mainfrom
jif/async-context-contributor
May 13, 2026
Merged

Make context contributors async#22491
jif-oai merged 2 commits into
mainfrom
jif/async-context-contributor

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 13, 2026

Summary

  • make ContextContributor return a boxed Send future
  • await context contributors during initial context assembly
  • update existing contributors and extension-api examples for the async contract

Testing

  • cargo test -p codex-extension-api --examples
  • cargo test -p codex-git-attribution
  • cargo test -p codex-core build_initial_context_includes_git_attribution_from_extensions -- --nocapture
  • cargo test -p codex-core build_initial_context_omits_git_attribution_when_feature_is_disabled -- --nocapture
  • cargo test -p codex-core (fails in unrelated agent::control::tests::spawn_agent_fork_last_n_turns_keeps_only_recent_turns stack overflow)
  • just fix -p codex-extension-api
  • just fix -p codex-git-attribution
  • just fix -p codex-core
  • cargo clippy -p codex-extension-api --examples

@jif-oai jif-oai requested a review from a team as a code owner May 13, 2026 13:47
@jif-oai jif-oai changed the base branch from jif/tool-3 to main May 13, 2026 13:52
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 13, 2026

@codex review

@jif-oai jif-oai changed the base branch from main to jif/tool-3 May 13, 2026 13:52
@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai force-pushed the jif/async-context-contributor branch from b6a8a10 to 1e7ca5a Compare May 13, 2026 14:26
@jif-oai jif-oai changed the base branch from jif/tool-3 to main May 13, 2026 14:26
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 13, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai jif-oai merged commit 68e045a into main May 13, 2026
25 of 26 checks passed
@jif-oai jif-oai deleted the jif/async-context-contributor branch May 13, 2026 14:43
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant