Add presentation hint for quiet managed hooks#22493
Open
abhinav-oai wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3648614f8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
I really wish this issue were given some priority - its a real mess of a UX having the tool dump its output every call. |
…visibility-hint # Conflicts: # codex-rs/app-server-protocol/schema/json/ServerNotification.json # codex-rs/tui/src/history_cell.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hooks can run on every turn, which makes routine hook activity noisy in the client. Admins may want to silence hooks such that they're only surfaces when there are E.rrors or other "steering" actions like a Block or Feedback.
What
visibility_hintwith the narrow shapedefault | hiddenhiddento take effect only for managed hook sources, keeping the user-facing hook config surface unchangedReviewer Note
Most of the diff is just plumbing, the key file to review is
codex-rs/tui/src/history_cell/hook_cell.rsPresentation rules
defaultdefaultdefaulthiddenhiddenhiddenContextentrieshiddenContextplus user-facing output such asWarninghiddenBlocked,Failed, orStopped