Conversation
pakrym-oai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
thread_start_params_include_review_policy_when_review_policy_is_manual_onlybuilds aConfigwith a temporaryCODEX_HOME, butConfigBuilder::default()can still load host-managed configuration. On local macOS machines with enterprise-managed Codex config, that host state can leak into the test and change the resulting config, even though CI does not have the same managed config source.This makes the test environment-dependent: it can pass in CI while failing locally for developers who have managed configuration installed.
What Changed
codex-rs/exec/src/lib_tests.rsso the test callsLoaderOverrides::without_managed_config_for_tests()throughConfigBuilder::loader_overrides(...).CODEX_HOME, temporary cwd, and explicitapprovals_reviewerharness override.Verification
cargo test -p codex-exec thread_start_params_include_review_policy_when_review_policy_is_manual_only